mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <>
Subject Review Request 44580: Made changes to the executor library around managing connections.
Date Wed, 09 Mar 2016 18:03:22 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Vinod Kone.

Bugs: MESOS-4858

Repository: mesos


This change makes the following modifications to the library:

- Removes passing connection objects to `defer` callbacks as it can
sometimes lead to deadlocks around destruction in the same execution
- Introduced 3 additional states `CONNECTING`, `SUBSCRIBING` and
`SUBSCRIBED`. The `CONNECTING` state helps us in identifying if a
connection attempt is in progress while the latter two states allows
us to drop subscribe calls if one is already is in progress.
- Creates a random `connectionID` to demarcate a new connection
instance and  allowing to discard a state connection attempt.
- Changes around setting the recovery timeout timer only once.
This allows us to later discard the recoveryTimeout callback
if we connected with the agent at a later point of time.


  src/executor/executor.cpp c3e95ea7e4edf78f2a65ddc15e213aba66e69db2 



make check


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message