mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44467: Implemented local puller shell command test.
Date Wed, 09 Mar 2016 23:14:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44467/#review122826
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/provisioner_docker_tests.cpp (line 333)
<https://reviews.apache.org/r/44467/#comment184919>

    Why do you need this? Can you just do:
    ```
    DOckerArchive::create(...)?
    ```



src/tests/containerizer/provisioner_docker_tests.cpp (line 338)
<https://reviews.apache.org/r/44467/#comment184920>

    ASSERT_TRUE


- Jie Yu


On March 7, 2016, 9:46 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44467/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4813
>     https://issues.apache.org/jira/browse/MESOS-4813
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented local puller shell command test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 5b685bfd842d0d98e8ea5ec5ddea8d2cd893dd81

> 
> Diff: https://reviews.apache.org/r/44467/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message