mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 44191: Avoided external linkage for master constants.
Date Fri, 11 Mar 2016 18:31:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44191/
-----------------------------------------------------------

(Updated March 11, 2016, 6:31 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4790
    https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description
-------

We were only using external linkage to workaround bugs in ancient
(4.1.x) of GCC. We can also mark most of these constants `constexpr`,
which should be both slightly more efficient (in theory) and
safer (see MESOS-1023).


Diffs (updated)
-----

  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44191/diff/


Testing
-------

make check

Note that I left a few string constants as `const std::string`; you might arguably want them
to be `constexpr char[]` (per Google Style Guide).


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message