mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <>
Subject Re: Review Request 44363: Added stubs for the Nvidia GPU device isolator.
Date Mon, 14 Mar 2016 07:37:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 14, 2016, 7:37 a.m.)

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Addressed all of bmahler's comments.

Bugs: MESOS-4623

Repository: mesos


This is the first isolator to fall under the category of cgroup
devices. However, we do not yet have a generic cgroup device isolator
(nor will we in the very near future). As such, I have preemptively
created the nvidia gpu isolator in the directory hierarchy under the


in order to easily allow them to fall under the category of gpu
devices later on.

In this stub implementation, initialization of the agent will
fail if the nvidia gpu isolator is enabled via the agent --isolation
flag. That is --isolation="cgroups/devices/gpu/nvidia". In a
subsequent commit we will fill in the guts to actually enable the
proper isolation.

The flags documentation has been udpated accordingly.

Diffs (updated)

  docs/ 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b 
  src/ f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/slave/containerizer/mesos/containerizer.cpp af3ff5750649497d8852b4761c78d4cae5455a02

  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp PRE-CREATION 
  src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd 


Testing (updated)

Running `make -j` doesn't cause any compilation errors.

A forthcoming unit test exercises the isolator path even with these stubs.


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message