mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 44364: Added infrastructure for Nvidia GPU tests and a simple test to start.
Date Mon, 14 Mar 2016 07:40:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/
-----------------------------------------------------------

(Updated March 14, 2016, 7:40 a.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
-------

Addressed all of bmahler's comments.


Summary (updated)
-----------------

Added infrastructure for Nvidia GPU tests and a simple test to start.


Bugs: MESOS-4863
    https://issues.apache.org/jira/browse/MESOS-4863


Repository: mesos


Description (updated)
-------

Added infrastructure for Nvidia GPU tests and a simple test to start.


Diffs (updated)
-----

  src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44364/diff/


Testing (updated)
-------

I temporarily enabled the test and ran it with the expected error seen below.  This shows
that we are actually trying to run with with the `cgroups/devices/nvidia/gpus` isolator, we
just don't have the guts filled in yet.

```
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from NvidiaGpuTest
[ RUN      ] NvidiaGpuTest.ROOT_CGROUPS_IsolatorCreationTest
../../src/tests/containerizer/nvidia_gpu_isolator_tests.cpp:67: Failure
containerizer: Could not create isolator 'cgroups/devices/gpus/nvidia': Cgroups Nvidia GPU
isolation currently not supported.
[  FAILED  ] NvidiaGpuTest.ROOT_CGROUPS_IsolatorCreationTest (525 ms)
[----------] 1 test from NvidiaGpuTest (525 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (560 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] NvidiaGpuTest.ROOT_CGROUPS_IsolatorCreationTest

 1 FAILED TEST
```

I then commented out the line setting `flags.isolation`, and everything succeeded as expected.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message