mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 44621: Added tests for http endpoints with bad authentication.
Date Mon, 14 Mar 2016 08:11:40 GMT


> On March 13, 2016, 12:26 a.m., Adam B wrote:
> > src/tests/master_tests.cpp, line 4265
> > <https://reviews.apache.org/r/44621/diff/4/?file=1296326#file1296326line4265>
> >
> >     There is no GET request allowed on /weights (yet), so it's interesting to me
that this part of the test passes. I would expect it to return 405 MethodNotAllowed. Or I
guess authentication happens before we even get to the handler to check the action?
> 
> Joerg Schad wrote:
>     I removed the test for now (especially as there is no http::put yet). Will add that
with a follow up patch.

Authn/z tests for PUT to the /weights endpoint are being added separately in https://reviews.apache.org/r/41790
See DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
And there's no longer a need for `process::http::put()` since `process::http::request()` has
been made public.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44621/#review123302
-----------------------------------------------------------


On March 13, 2016, 11:50 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44621/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4844
>     https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With enabling http authentication for http endpoints we should also add tests to check
> that http request to those endpoints return "401 Unauthorized" if queried without or
with
> bad credentials.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp 5a421d4e8740b5105518283943087869025cbfa6 
>   src/tests/master_tests.cpp e9ddd360fd87aed091f12a35f92df3f4e9c4190b 
>   src/tests/repair_tests.cpp cb38bb1b6717c3eb003323278cf8f6902394be7c 
>   src/tests/role_tests.cpp 2e23926143a2c09c6e1fee961a4ede6f7b3a275e 
> 
> Diff: https://reviews.apache.org/r/44621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message