mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 44765: Added description to endpoint help for frameworks and flags.
Date Mon, 14 Mar 2016 08:24:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44765/#review123376
-----------------------------------------------------------




src/master/http.cpp (line 737)
<https://reviews.apache.org/r/44765/#comment185617>

    s/of/about/



src/master/http.cpp (line 780)
<https://reviews.apache.org/r/44765/#comment185618>

    What about `Slave::Http::FLAGS_HELP()`?



src/master/http.cpp (line 786)
<https://reviews.apache.org/r/44765/#comment185619>

    s/provides information/shows/


- Adam B


On March 13, 2016, 2:29 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44765/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 2:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to endpoint help for frameworks and flags.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/flags.md 739d6bfae5ae35223d6bc7c4782ff0f16b868018 
>   docs/endpoints/master/frameworks.md 95c1f0e63f6a61d0e6622a8ec9d821a646656cfc 
>   src/master/http.cpp 6dec322ca4f7d81c2f070db4f54a0575a2b5c842 
> 
> Diff: https://reviews.apache.org/r/44765/diff/
> 
> 
> Testing
> -------
> 
> Viewed in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message