mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.
Date Mon, 14 Mar 2016 09:38:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review123389
-----------------------------------------------------------




src/authentication/http/basic_authenticator_factory.cpp (lines 63 - 64)
<https://reviews.apache.org/r/44678/#comment185645>

    Seems like you're changing the meaning of the parameters in `BasicAuthenticatorFactory::create(Parameters)`.
Before, `Parameters` was just a convenient protobuf for username/password key-value pairs.
Now, you're interpreting the keys as module parameter names. Are you actually introducing
a new "authentication_realm" module parameter to the Authenticator module interface?
    Why not just use `BasicAuthenticatorFactory::create(const string realm, const Parameters&
parameters)`?



src/authentication/http/basic_authenticator_factory.cpp (line 70)
<https://reviews.apache.org/r/44678/#comment185647>

    s/`_credentials`/`credentials_`/
    
    "Some trailing underscores are used to distinguish between similar variables in the same
scope (think prime symbols)"
    "We prepend constructor and function arguments with a leading underscore"



src/tests/http_authentication_tests.cpp (line 104)
<https://reviews.apache.org/r/44678/#comment185642>

    No `auto` here, please. I may happen to know that Parameters is a `repeated Parameter
parameter`, but others may not, so it doesn't fit the "type omitted on the left is already
fully stated on the right" qualification.


- Adam B


On March 13, 2016, 9:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44678/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 9:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4850
>     https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified basic HTTP authenticator creator to accept realm.
> 
> To accommodate different authentication realms for the master and agent, the default
basic HTTP authenticator needs to accept its authentication realm as a parameter. This patch
adds this parameter and modifies the HTTP authentication tests to validate it appropriately.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

>   src/authentication/http/basic_authenticator_factory.cpp 62f851685db3b42c52bbcb7cff3e4f4703004ed7

>   src/master/master.cpp 255b4d1ba029d7f9cfb86138c66a25d0dffa30e0 
>   src/tests/http_authentication_tests.cpp cf2bb762272fa38e04e5c26aef2858300bbd0459 
> 
> Diff: https://reviews.apache.org/r/44678/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on both OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message