mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.
Date Wed, 16 Mar 2016 13:16:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/#review123785
-----------------------------------------------------------



Committed with the following formatting fixes.


src/tests/cluster.cpp (lines 157 - 158)
<https://reviews.apache.org/r/43613/#comment186038>

    Fits on one line.



src/tests/cluster.cpp (lines 220 - 221)
<https://reviews.apache.org/r/43613/#comment186039>

    Fits on one line.



src/tests/cluster.cpp (lines 240 - 241)
<https://reviews.apache.org/r/43613/#comment186041>

    Fits on one line.



src/tests/cluster.cpp (lines 249 - 250)
<https://reviews.apache.org/r/43613/#comment186042>

    Fits on one line.



src/tests/cluster.cpp (lines 266 - 268)
<https://reviews.apache.org/r/43613/#comment186043>

    ```
          slaveRemovalLimiter.isSome() ? slaveRemovalLimiter
                                       : master->slaveRemovalLimiter,
    ```



src/tests/cluster.cpp (lines 274 - 276)
<https://reviews.apache.org/r/43613/#comment186044>

    ```
        StandaloneMasterDetector* _detector = CHECK_NOTNULL(
            dynamic_cast<StandaloneMasterDetector*>(master->detector.get()));
    ```


- Michael Park


On March 14, 2016, 9:31 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43613/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 9:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Artem Harutyunyan, and Michael
Park.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
>     https://issues.apache.org/jira/browse/MESOS-4633
>     https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope of test objects
to the test body.
> 
> Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  The `Slave`
object performs cleanup originally found in `cluster::Slave::stop`.  `cluster::Master::start`
and `cluster::Slave::start` were changed to factory methods.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
>   src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 
> 
> Diff: https://reviews.apache.org/r/43613/diff/
> 
> 
> Testing
> -------
> 
> Tests are run at the end of this review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message