mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 43884: Added allocator metrics for used quotas.
Date Fri, 18 Mar 2016 16:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/
-----------------------------------------------------------

(Updated March 18, 2016, 5:08 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
-------

Review comments from BenM.


Bugs: MESOS-4723
    https://issues.apache.org/jira/browse/MESOS-4723


Repository: mesos


Description
-------

Added allocator metrics for used quotas.


Diffs (updated)
-----

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 0c622b8569bc79ae4e365a57e463ca5349356713 
  src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32 
  src/master/allocator/mesos/metrics.hpp d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
  src/master/allocator/mesos/metrics.cpp 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
  src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/43884/diff/


Testing
-------

make check (OS X)

I confirmed that this does not lead to general performance regressions in the allocator; this
is partially expected since the added code only inserts metrics in the allocator while the
actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message