mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 43884: Added allocator metrics for used quotas.
Date Tue, 22 Mar 2016 19:10:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review124836
-----------------------------------------------------------


Fix it, then Ship it!




Looks good! I'll make some minor adjustments based on the comments prior to getting this committed.


docs/monitoring.md (lines 876 - 890)
<https://reviews.apache.org/r/43884/#comment187539>

    Hm.. looks like the "resources/" prefix was left out? Any reason for that? The "resources/"
prefix helps us if we add any quota metrics that are not tied to the resources.



docs/monitoring.md (line 880)
<https://reviews.apache.org/r/43884/#comment187526>

    "offered or allocated" here as well?



src/master/allocator/mesos/hierarchical.cpp (line 1697)
<https://reviews.apache.org/r/43884/#comment187540>

    Just 2 spaces need here instead of 4



src/master/allocator/mesos/metrics.hpp (lines 58 - 64)
<https://reviews.apache.org/r/43884/#comment187543>

    s/resource kind/resource/ just because we haven't generally been using the work "kind"
in this manner to my knowledge
    
    Only 2 spaces needed on the continuation lines here.



src/master/allocator/mesos/metrics.cpp (line 21)
<https://reviews.apache.org/r/43884/#comment187554>

    This should go above process and stout here?



src/master/allocator/mesos/metrics.cpp (line 37)
<https://reviews.apache.org/r/43884/#comment187544>

    How about a .self() here insted of taking a reference?



src/master/allocator/mesos/metrics.cpp (line 92)
<https://reviews.apache.org/r/43884/#comment187551>

    Any reason not to just pass the 'gauge' here rather than doing the lookup?
    
    ```
          allocated.put(resource.name(), gauge);
          process::metrics::add(gauge);
    ```
    
    Ditto below.



src/master/allocator/mesos/metrics.cpp (line 102)
<https://reviews.apache.org/r/43884/#comment187547>

    2 spaces unless wrapping an open parenthesis



src/master/allocator/mesos/metrics.cpp (line 103)
<https://reviews.apache.org/r/43884/#comment187546>

    you can omit the 'allocator' here to use a deferred context where libprocess manages the
execution, see here: https://github.com/apache/mesos/tree/0.28.0/3rdparty/libprocess#defer


- Ben Mahler


On March 18, 2016, 4:08 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
>     https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 0c622b8569bc79ae4e365a57e463ca5349356713

>   src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32

>   src/master/allocator/mesos/metrics.hpp d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
>   src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05

> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the allocator;
this is partially expected since the added code only inserts metrics in the allocator while
the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message