mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45186: Implemented user specified system config files support.
Date Thu, 24 Mar 2016 02:06:04 GMT


> On 三月 23, 2016, 6:51 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233
> > <https://reviews.apache.org/r/45186/diff/1/?file=1311199#file1311199line231>
> >
> >     Put this check to the block of 
> >     if (flags.system_config_files.isSome()) {
> >     } ?
> 
> Gilbert Song wrote:
>     It can be a case that any of the four default sys config files missing on the host
for some os env, so we check all files which will be bind mounted here.

Just curious for which system/os does the four default sys config files will not exist?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124976
-----------------------------------------------------------


On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> -----------------------------------------------------------
> 
> (Updated 三月 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3003
>     https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp f97a9a92895387a9d504810a2ae971cfb5d3dbb4

> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message