mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
Date Thu, 24 Mar 2016 16:38:11 GMT


> On March 17, 2016, 8:34 p.m., Michael Park wrote:
> > support/clang-format, line 3
> > <https://reviews.apache.org/r/44758/diff/3/?file=1300622#file1300622line3>
> >
> >     Can we uncomment this? Our style by definition is
> >     
> >     > The Mesos codebase follows the Google C++ Style Guide with some notable
differences, as described below.
> >     
> >     So basing off of Google and overriding the parts that don't match accurately
defines our style guide.
> 
> Yong Tang wrote:
>     Thanks Michael. Just updated the review request. Let me know if there are other issues.

Hi Michael, if there is no additional issues, can this review request be merged?


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124090
-----------------------------------------------------------


On March 17, 2016, 9:08 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
>     https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message