mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 45186: Implemented user specified system config files support.
Date Thu, 24 Mar 2016 16:49:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review125287
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 207)
<https://reviews.apache.org/r/45186/#comment188079>

    We should use the path::absolute method here



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 219)
<https://reviews.apache.org/r/45186/#comment188080>

    Also log when we cannot find it.


- Timothy Chen


On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3003
>     https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp f97a9a92895387a9d504810a2ae971cfb5d3dbb4

> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message