mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45249: Added new '/files' endpoints tests using authentication.
Date Thu, 24 Mar 2016 20:33:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/
-----------------------------------------------------------

(Updated March 24, 2016, 8:33 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.


Changes
-------

Put the HTTP authenticator in an RAII wrapper.


Bugs: MESOS-4956
    https://issues.apache.org/jira/browse/MESOS-4956


Repository: mesos


Description
-------

New tests were added to the FilesTests, and existing tests were modified, to probe the endpoints'
behavior with and without HTTP authentication. Tests were also added for `/flags/debug`, as
there were no pre-existing tests for that endpoint.


Diffs (updated)
-----

  src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 

Diff: https://reviews.apache.org/r/45249/diff/


Testing
-------

`sudo make check` was used to test on OSX and CentOS 7.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message