mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Niemitz <sniem...@twitter.com>
Subject Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly
Date Thu, 24 Mar 2016 23:54:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/
-----------------------------------------------------------

(Updated March 24, 2016, 11:54 p.m.)


Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.


Changes
-------

ran sudo make check, all docker ROOT tests succeed now.


Bugs: MESOS-2617
    https://issues.apache.org/jira/browse/MESOS-2617


Repository: mesos


Description
-------

Fix for docker containerizer not configuring CFS quotas correctly.

It would be nice to refactor all this isolation code in a way that can be shared between all
containerizers, as this is basically just copied from the CgroupsCpushareIsolator, but that's
a much bigger undertaking.


Diffs (updated)
-----

  src/slave/containerizer/docker.hpp 79cd955e9c241becff52cc4bbef81dcc16802ee7 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 

Diff: https://reviews.apache.org/r/33174/diff/


Testing
-------


Thanks,

Steve Niemitz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message