mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45249: Added a new '/files' endpoints test using authentication.
Date Thu, 24 Mar 2016 23:59:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/
-----------------------------------------------------------

(Updated March 24, 2016, 11:59 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.


Changes
-------

Removed the RAII wrapper :-) Manage the authenticator lifecycle in the test fixture setup/teardown.


Summary (updated)
-----------------

Added a new '/files' endpoints test using authentication.


Bugs: MESOS-4956
    https://issues.apache.org/jira/browse/MESOS-4956


Repository: mesos


Description (updated)
-------

A new test was added (FilesTest.AuthenticationTest) to the FilesTests, and existing tests
were modified, to probe the endpoints' behavior with and without HTTP authentication.


Diffs (updated)
-----

  src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 

Diff: https://reviews.apache.org/r/45249/diff/


Testing
-------

`sudo make check` was used to test on OSX and CentOS 7.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message