mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45073: Restructured authentication.md to group common flags.
Date Fri, 25 Mar 2016 22:36:06 GMT


> On March 20, 2016, 5:44 p.m., Greg Mann wrote:
> > Personally, I'm not convinced that this is a useful way to format our flag documentation.
I've been meaning to propose eliminating it from 'configuration.md'. I think it's more confusing
to have the lists of flags broken up into multiple pieces. I'm guessing that most users come
to the documentation either looking for a specific flag of either the master or agent, or
they want to look over the entire list of flags for either the master or agent. In either
case, I think that splitting up the flags makes it a little harder for them to find what they
want. Thoughts?
> 
> Joerg Schad wrote:
>     From I software engineering perspective I hate to duplicate information which I then
have to keep in sync :-). Secondly, from a user perspective (imagine me writing some chef/puppet
scripts to setupmy cluster) it is nice to know which flags are applicable for both.

I do see your point about duplicated information. However, I guess I don't see the benefit
from the user perspective: if I'm writing scripts to set up my cluster, at a given moment
I'm probably looking for flags for _either_ the master _or_ the agent, so I would expect that
it's a bit easier to just have all the flags for the relevant binary in one place?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45073/#review124452
-----------------------------------------------------------


On March 19, 2016, 11:51 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45073/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 11:51 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Restructured authentication.md to group common flags.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 
> 
> Diff: https://reviews.apache.org/r/45073/diff/
> 
> 
> Testing
> -------
> 
> viewed via gist: https://gist.github.com/joerg84/63e5919fef724b5c3508 and docker website
container
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message