mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 45122: Updated tests for deletion of persistent volumes.
Date Sun, 27 Mar 2016 22:07:36 GMT


> On March 26, 2016, 12:53 a.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 243
> > <https://reviews.apache.org/r/45122/diff/1/?file=1308848#file1308848line243>
> >
> >     Can we create a new test, instead of piggyback on this test? In the new test,
you can test the 'creation' of persistent volume as well for PATH type disk.

I looked at creating a new test, although it seemed like it would just duplicate all of the
existing `SendingCheckpointResourcesMessage` test. For now I haven't made a new test, although
I can if you feel strongly about it.

Re: testing the creation of PATH disks, can you clarify? AFAIK we're testing that right now.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45122/#review125499
-----------------------------------------------------------


On March 27, 2016, 10:05 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45122/
> -----------------------------------------------------------
> 
> (Updated March 27, 2016, 10:05 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
>     https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated tests for deletion of persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 
> 
> Diff: https://reviews.apache.org/r/45122/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message