mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 45249: Added a new '/files' endpoints test using authentication.
Date Mon, 28 Mar 2016 08:20:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/#review125606
-----------------------------------------------------------


Fix it, then Ship it!




Thanks! I'll move the namespace= and indent those EXPECT params, then commit it


src/tests/files_tests.cpp (line 51)
<https://reviews.apache.org/r/45249/#comment188478>

    namespace= declarations always seem to go above the using's, right after includes.



src/tests/files_tests.cpp (line 357)
<https://reviews.apache.org/r/45249/#comment188479>

    Not sure why this needed to be its own function if it's only used once. Maybe you anticipate
more tests using it in the future?



src/tests/files_tests.cpp (line 375)
<https://reviews.apache.org/r/45249/#comment188482>

    Let's align this with `response`, since that won't create too much jaggedness. Otherwise,
we'd prefer each parameter get its own line.


- Adam B


On March 25, 2016, 5:07 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45249/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 5:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.
> 
> 
> Bugs: MESOS-4956
>     https://issues.apache.org/jira/browse/MESOS-4956
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A new test was added (FilesTest.AuthenticationTest) to probe the `/files/*` endpoints'
behavior when HTTP authentication is enabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 
> 
> Diff: https://reviews.apache.org/r/45249/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` and `GTEST_FILTER="FilesTest.AuthenticationTest" build/bin/mesos-tests.sh
--gtest_repeat=1000 --gtest_break_on_failure=1` were used to test on OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message