mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 45232: Introduced subprocess watchdog option [3/7].
Date Mon, 28 Mar 2016 14:10:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
-----------------------------------------------------------

(Updated March 28, 2016, 2:10 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-----------------

Introduced subprocess watchdog option [3/7].


Repository: mesos


Description
-------

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs
-----

  3rdparty/libprocess/include/process/subprocess.hpp e0c306aa5cf5f393abb73768bbd287c45730f076

  3rdparty/libprocess/src/subprocess.cpp b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 09e46eb1ce10a6c38cc364077f0b5952579d46e7


Diff: https://reviews.apache.org/r/45232/diff/


Testing
-------

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message