mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Mon, 28 Mar 2016 15:13:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125635
-----------------------------------------------------------




src/docker/docker.cpp (line 555)
<https://reviews.apache.org/r/42516/#comment188515>

    Indentation seems off ? I guess youc an align it with `ContainerInfo` above?



src/docker/docker.cpp (line 556)
<https://reviews.apache.org/r/42516/#comment188512>

    We generally don't use `this`. Maybe
    
    Try<Nothing> validate = validateVersion(...) ?



src/docker/docker.cpp (line 562)
<https://reviews.apache.org/r/42516/#comment188508>

    We should make sure the user is not trying to specify  more than one network for this
container (multiple `NetworkInfo`). Docker 1.9 supports multiple user networks but the container
can be connected to more than one network only after being started (using `docker network
connect`) which is kind of useless. Docker 1.10 apparently allows you to attach container
to multiple network but not using the `docker run` command, so doesn't fit the model for `DockerContainerizer`.


- Avinash sridharan


On March 28, 2016, 10:51 a.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 10:51 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 
>   include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f 
>   src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message