mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 45386: Fix container destroy provisioning race.
Date Mon, 28 Mar 2016 16:03:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45386/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-5023
    https://issues.apache.org/jira/browse/MESOS-5023


Repository: mesos


Description
-------

Fix container destroy provisioning race.

The flaky test results from `_launch()` and `___destroy()` are waiting for the same future
to be ready. It is possible that once the future is ready and send callbacks to the two methods
above, `___destroy()` and its dependencies finish before `_lauch()` starts, which erase the
`containerId` in the hashmap.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp e7f7e7fd1304e14dbfaab8b53cea16efc0417911


Diff: https://reviews.apache.org/r/45386/diff/


Testing
-------

make check

./bin/mesos-tests.sh --gtest_filter="*DestroyWhileProvisioning*" --gtest_repeat=-1 --gtest_break_on_failure


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message