mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.
Date Tue, 29 Mar 2016 08:57:58 GMT


> On March 29, 2016, 3:30 a.m., Neil Conway wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 127
> > <https://reviews.apache.org/r/42860/diff/4/?file=1317602#file1317602line127>
> >
> >     What does "flat" mean, here? Also, is it worth adding a `CHECK` that all paths
are absolute?

`flat` means the path is not like "/a/../c" or "/a//b". Do you think we need add a method
like `path::simplify()` to flat the path passed in?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review125801
-----------------------------------------------------------


On March 29, 2016, 8:56 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-4521
>     https://issues.apache.org/jira/browse/MESOS-4521
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add paths::overlapping to check whether paths are overlapping.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp ef538045a8b7a1e3d8962c869317d86a85e0259f

>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 6dff5e76e0e15098c5a262adc50bfcb65f933697

> 
> Diff: https://reviews.apache.org/r/42860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message