mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Tue, 29 Mar 2016 09:21:44 GMT


> On 三月 29, 2016, 8:54 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, line 567
> > <https://reviews.apache.org/r/42516/diff/16/?file=1317647#file1317647line567>
> >
> >     Can you please add some comments here: If there are multiple network infos,
the docker containerizer will only take the first network info.
> >     
> >     It is a tricky part here, if an operator defined many network infos and only
the first one do not have network name, error will return here.
> 
> Ezra Silvera wrote:
>     We need to resolve this "many network infos" once and for all :-)  
>     In Docker you can't specify more then a single network during the run/create command.
We are handling here the run command so in this case we expect a single NetworkInfo element,
anything else will be an error. Currently we choose to just ignore it, we can actually fail
the operation for elements > 1 if you think it will be more clear.

I think that logging some warning message may be good enough if there are multiple networks.

Can you please also add @jieyu as he is also tracking this issue and we can get some comments
from him ;-)


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125841
-----------------------------------------------------------


On 三月 29, 2016, 8:34 a.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated 三月 29, 2016, 8:34 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 
>   include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f 
>   src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message