mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Tue, 29 Mar 2016 18:01:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125921
-----------------------------------------------------------




src/docker/docker.cpp (line 568)
<https://reviews.apache.org/r/42516/#comment188831>

    Maybe s/ Found .../Found multiple networks specified for this container. We can only attach
docker containers to a single network/
    
    We try to avoid variable names in `Error` since it becomes cryptic. Also, I guess the
limiation is of the `DockerContainerizer` rather than `Docker`?


- Avinash sridharan


On March 29, 2016, 4:33 p.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 
>   include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f 
>   src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message