| Yi Sun |
Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead. |
Mon, 14 Mar, 23:51 |
| Anurag Singh |
Re: Review Request 44545: Separated standalone and zookeeper classes. |
Mon, 14 Mar, 23:51 |
| Anurag Singh |
Re: Review Request 44546: Moved functions in promises to a common header file. |
Mon, 14 Mar, 23:52 |
| Anurag Singh |
Re: Review Request 44547: Added functions in promises to the collect header. |
Mon, 14 Mar, 23:52 |
| Anurag Singh |
Re: Review Request 44289: Added support for contender and detector modules. |
Mon, 14 Mar, 23:52 |
| Anurag Singh |
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector. |
Mon, 14 Mar, 23:52 |
| Anurag Singh |
Re: Review Request 44670: Added master_detector and master_contender flags. |
Mon, 14 Mar, 23:53 |
| Yi Sun |
Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`. |
Mon, 14 Mar, 23:57 |
| Anurag Singh |
Re: Review Request 44545: Separated standalone and zookeeper classes. |
Tue, 15 Mar, 00:01 |
| Gilbert Song |
Re: Review Request 44753: Fixed runtime isolator tests out of disk issue. |
Tue, 15 Mar, 00:22 |
| Qian Zhang |
Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator. |
Tue, 15 Mar, 00:29 |
| Avinash sridharan |
Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator. |
Tue, 15 Mar, 00:41 |
| Guangya Liu |
Re: Review Request 44753: Fixed runtime isolator tests out of disk issue. |
Tue, 15 Mar, 00:58 |
| Guangya Liu |
Re: Review Request 44753: Fixed runtime isolator tests out of disk issue. |
Tue, 15 Mar, 01:06 |
| Qian Zhang |
Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator. |
Tue, 15 Mar, 01:28 |
| Guangya Liu |
Re: Review Request 44753: Fixed runtime isolator tests out of disk issue. |
Tue, 15 Mar, 01:28 |
| Yong Tang |
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory. |
Tue, 15 Mar, 01:38 |
| Yong Tang |
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory. |
Tue, 15 Mar, 01:39 |
| haosdent huang |
Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`. |
Tue, 15 Mar, 02:02 |
| Qian Zhang |
Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator. |
Tue, 15 Mar, 02:03 |
| haosdent huang |
Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover. |
Tue, 15 Mar, 02:03 |
| haosdent huang |
Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover. |
Tue, 15 Mar, 02:04 |
| haosdent huang |
Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover. |
Tue, 15 Mar, 02:05 |
| haosdent huang |
Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover. |
Tue, 15 Mar, 02:06 |
| haosdent huang |
Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover. |
Tue, 15 Mar, 02:06 |
| haosdent huang |
Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases. |
Tue, 15 Mar, 02:08 |
| Ben Mahler |
Re: Review Request 44626: Fixed whitespaces in mesos.proto. |
Tue, 15 Mar, 02:12 |
| Ben Mahler |
Re: Review Request 44627: Removed a stale comment in the 1.0 mesos.proto. |
Tue, 15 Mar, 02:14 |
| Ben Mahler |
Re: Review Request 44628: Fixed a comment and ordering in mesos.proto. |
Tue, 15 Mar, 02:15 |
| Ben Mahler |
Re: Review Request 44629: Fixed ordering and inconsistencies in slave constants. |
Tue, 15 Mar, 02:18 |
| Kevin Klues |
Re: Review Request 44777: Added a flags parser for vector<unsigned int> to stout. |
Tue, 15 Mar, 02:23 |
| Ben Mahler |
Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant. |
Tue, 15 Mar, 02:28 |
| Neil Conway |
Re: Review Request 44777: Added a flags parser for vector<unsigned int> to stout. |
Tue, 15 Mar, 02:28 |
| Ben Mahler |
Re: Review Request 44631: Cleaned up the comment around executor shutdown event. |
Tue, 15 Mar, 03:06 |
| Qian Zhang |
Re: Review Request 44549: Introduced a protobuf message "NetworkConfig". |
Tue, 15 Mar, 03:08 |
| Ben Mahler |
Re: Review Request 44634: Updated the log message in the HTTP API executor library. |
Tue, 15 Mar, 03:08 |
| Ben Mahler |
Re: Review Request 44634: Updated the log message in the HTTP API executor library. |
Tue, 15 Mar, 03:09 |
| Kevin Klues |
Re: Review Request 44777: Added a flags parser for vector<unsigned int> to src/common/parse.hpp. |
Tue, 15 Mar, 03:11 |
| Ben Mahler |
Re: Review Request 44635: Corrected the log message and variable name in executor library. |
Tue, 15 Mar, 03:13 |
| Ben Mahler |
Re: Review Request 44635: Corrected the log message and variable name in executor library. |
Tue, 15 Mar, 03:15 |
| Ben Mahler |
Re: Review Request 43763: Passed `Duration` as const reference in the executor library. |
Tue, 15 Mar, 03:17 |
| Ben Mahler |
Re: Review Request 44650: Omitted names of unused parameters in executor library. |
Tue, 15 Mar, 03:18 |
| Ben Mahler |
Re: Review Request 44651: Fixed formatting in executor library. |
Tue, 15 Mar, 03:19 |
| Ben Mahler |
Re: Review Request 44652: Omitted names of unused parameters in command executor. |
Tue, 15 Mar, 03:21 |
| Mesos ReviewBot |
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory. |
Tue, 15 Mar, 03:33 |
| haosdent huang |
Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`. |
Tue, 15 Mar, 03:52 |
| Mesos ReviewBot |
Re: Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases. |
Tue, 15 Mar, 05:51 |
| Neil Conway |
Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged. |
Tue, 15 Mar, 05:54 |
| Neil Conway |
Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged. |
Tue, 15 Mar, 05:57 |
| Jie Yu |
Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator. |
Tue, 15 Mar, 06:07 |
| Anurag Singh |
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes. |
Tue, 15 Mar, 06:16 |
| Anurag Singh |
Re: Review Request 44288: Changed MasterDetector/Contender namespace. |
Tue, 15 Mar, 06:17 |
| Anurag Singh |
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions. |
Tue, 15 Mar, 06:17 |
| Anurag Singh |
Re: Review Request 44544: Moved contender and detector definitions into separate directories. |
Tue, 15 Mar, 06:17 |
| Anurag Singh |
Re: Review Request 44545: Separated standalone and zookeeper classes. |
Tue, 15 Mar, 06:17 |
| Anurag Singh |
Re: Review Request 44546: Moved functions in promises to a common header file. |
Tue, 15 Mar, 06:18 |
| Anurag Singh |
Re: Review Request 44547: Added functions in promises to the collect header. |
Tue, 15 Mar, 06:18 |
| Anurag Singh |
Re: Review Request 44289: Added support for contender and detector modules. |
Tue, 15 Mar, 06:18 |
| Anurag Singh |
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector. |
Tue, 15 Mar, 06:18 |
| Anurag Singh |
Re: Review Request 44670: Added master_detector and master_contender flags. |
Tue, 15 Mar, 06:18 |
| Jay Guo |
Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 06:54 |
| haosdent huang |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 07:01 |
| haosdent huang |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 07:04 |
| haosdent huang |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 07:11 |
| Guangya Liu |
Review Request 44837: Added force_pull_image to Image protobuf. |
Tue, 15 Mar, 07:18 |
| Guangya Liu |
Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:18 |
| haosdent huang |
Re: Review Request 44837: Added force_pull_image to Image protobuf. |
Tue, 15 Mar, 07:26 |
| Guangya Liu |
Re: Review Request 44837: Added force_pull_image to Image protobuf. |
Tue, 15 Mar, 07:31 |
| haosdent huang |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:34 |
| haosdent huang |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:42 |
| Jay Guo |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 07:49 |
| Jay Guo |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 07:50 |
| Guangya Liu |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:54 |
| Guangya Liu |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:54 |
| Guangya Liu |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 07:55 |
| Jay Guo |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 08:00 |
| haosdent huang |
Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid. |
Tue, 15 Mar, 08:05 |
| Qian Zhang |
Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API. |
Tue, 15 Mar, 08:10 |
| haosdent huang |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 08:11 |
| haosdent huang |
Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker. |
Tue, 15 Mar, 08:12 |
| haosdent huang |
Re: Review Request 44837: Added force_pull_image to Image protobuf. |
Tue, 15 Mar, 08:12 |
| Mesos ReviewBot |
Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`. |
Tue, 15 Mar, 08:34 |
| Benjamin Bannier |
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory. |
Tue, 15 Mar, 08:45 |
| Guangya Liu |
Review Request 44839: Enabled mesos containerizer force_pull_image for appc. |
Tue, 15 Mar, 09:02 |
| Tomasz Janiszewski |
Review Request 44843: Replace NULL with nullptr. |
Tue, 15 Mar, 09:15 |
| Guangya Liu |
Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged. |
Tue, 15 Mar, 09:29 |
| haosdent huang |
Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc. |
Tue, 15 Mar, 09:47 |
| Jan Schlicht |
Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo. |
Tue, 15 Mar, 09:59 |
| Klaus Ma |
Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf. |
Tue, 15 Mar, 10:02 |
| Joerg Schad |
Re: Review Request 44515: Added agent flags for HTTP authentication. |
Tue, 15 Mar, 10:33 |
| Joerg Schad |
Re: Review Request 44515: Added agent flags for HTTP authentication. |
Tue, 15 Mar, 10:34 |
| Mesos ReviewBot |
Re: Review Request 44670: Added master_detector and master_contender flags. |
Tue, 15 Mar, 10:55 |
| Joerg Schad |
Re: Review Request 44650: Omitted names of unused parameters in executor library. |
Tue, 15 Mar, 11:12 |
| Joerg Schad |
Re: Review Request 44652: Omitted names of unused parameters in command executor. |
Tue, 15 Mar, 11:13 |
| Alexander Rukletsov |
Re: Review Request 44650: Omitted names of unused parameters in executor library. |
Tue, 15 Mar, 11:35 |
| Jan Schlicht |
Review Request 44846: Deprecated the plain text credential format. |
Tue, 15 Mar, 11:36 |
| Alexander Rukletsov |
Re: Review Request 44652: Omitted names of unused parameters in command executor. |
Tue, 15 Mar, 11:41 |
| Alexander Rukletsov |
Re: Review Request 44651: Fixed formatting in executor library. |
Tue, 15 Mar, 11:41 |
| Joerg Schad |
Re: Review Request 44846: Deprecated the plain text credential format. |
Tue, 15 Mar, 11:46 |
| Alexander Rukletsov |
Re: Review Request 44651: Fixed formatting in executor library. |
Tue, 15 Mar, 11:52 |