mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.
Date Sun, 01 May 2016 22:58:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46876/#review131272
-----------------------------------------------------------



Bad patch!

Reviews applied: [46876, 46870, 46869, 46868, 46867, 46866]

Failed command: ./support/apply-review.sh -n -r 46868

Error:
2016-05-01 22:58:40 URL:https://reviews.apache.org/r/46868/diff/raw/ [4583/4583] -> "46868.patch"
[1]
Total errors found: 0
Checking 3 files
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  src/common/http.cpp
libprocess:
  3rdparty/libprocess/include/process/metrics/metrics.hpp
  3rdparty/libprocess/src/metrics/metrics.cpp

Full log: https://builds.apache.org/job/mesos-reviewbot/12834/console

- Mesos ReviewBot


On May 1, 2016, 10:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46876/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 10:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some tests hit the '/metrics/snapshot' endpoint and
> must be updated to accomodate authorization. In
> particular, an authorizer had to be explicitly
> instantiated and used to initialize the master/agent
> in some tests so that they share the same authorizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
>   src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2 
>   src/tests/mesos.cpp 036c589f5aafc8c804b0fb4e5ad62df70e471e88 
>   src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1 
>   src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 
> 
> Diff: https://reviews.apache.org/r/46876/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message