mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46680: Fixed docker volume isolator const ref and vlog quotation.
Date Mon, 02 May 2016 17:08:01 GMT


> On April 26, 2016, 9:45 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 289-290
> > <https://reviews.apache.org/r/46680/diff/1/?file=1361131#file1361131line289>
> >
> >     According to https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#capture-by-reference
, seems we disallow capturing temporaries by reference?
> >     
> >     Can you please add some detail in description for why using reference here?

This is not temporary since driver() returns a const ref.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46680/#review130576
-----------------------------------------------------------


On April 26, 2016, 8:32 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46680/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 8:32 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed docker volume isolator const ref and vlog quotation.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d

> 
> Diff: https://reviews.apache.org/r/46680/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message