mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".
Date Tue, 03 May 2016 21:05:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review131538
-----------------------------------------------------------




src/tests/containerizer/docker_volume_isolator_tests.cpp (line 112)
<https://reviews.apache.org/r/46140/#comment195558>

    Should we use `MNT_DETACH` flag here?



src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 215 - 217)
<https://reviews.apache.org/r/46140/#comment195563>

    This test verifies that a docker volume is properly mounted to a container without rootfs,
and launches a command task that reads files from the mounted docker volume.



src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 272 - 273)
<https://reviews.apache.org/r/46140/#comment195572>

    Do we need it on this test?



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 276)
<https://reviews.apache.org/r/46140/#comment195574>

    Please apply the patch https://reviews.apache.org/r/46942/
    
    and the `container_path` should be a relative path here. E.g., `tmp/foo`. This should
be corresponding to the the path in your task.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 277)
<https://reviews.apache.org/r/46140/#comment195575>

    One more line above.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 281)
<https://reviews.apache.org/r/46140/#comment195578>

    Are you using this? Please remove if not.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 288)
<https://reviews.apache.org/r/46140/#comment195580>

    Kill this.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 292)
<https://reviews.apache.org/r/46140/#comment195579>

    ditto.



src/tests/containerizer/docker_volume_isolator_tests.cpp (line 294)
<https://reviews.apache.org/r/46140/#comment195581>

    Kill this.


- Gilbert Song


On May 3, 2016, 12:51 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
>     https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test "ROOT_CommandTaskNoRootfsSingleVolume".
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 070d52018e82ed3e46fb1b79714ffc4716f6a306

>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46140/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsSingleVolume"
--verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message