mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.
Date Thu, 05 May 2016 03:13:51 GMT


> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, line 89
> > <https://reviews.apache.org/r/46608/diff/1/?file=1358649#file1358649line89>
> >
> >     The initialization with `INVALID_HANDLE_VALUE` has no semantic meaning, right?
We should just leave it uninitialized, since we initialize it with the `duplicateHandle` call.

I think it makes sense to initialize it to a "safe" value, but it's fine to do it this way
too, so let's do that.


> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 199-200
> > <https://reviews.apache.org/r/46608/diff/1/?file=1358649#file1358649line199>
> >
> >     Is this because using `GENERIC_WRITE` with `FILE_SHARE_READ` is a no-op?

It's not a no-op, or I might not understand what you're saying. `FILE_SHARE_READ` will allow
other processes to read the file, which in this case I think is what we want. I can add a
comment.


> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, line 414
> > <https://reviews.apache.org/r/46608/diff/1/?file=1358649#file1358649line414>
> >
> >     Remove newline.

I wasn't sure of intent here. You mean, remove all similar newlines? because we do this in
other lambdas, too.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review131356
-----------------------------------------------------------


On May 5, 2016, 3:12 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 3:12 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
>     https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
>   3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message