mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 47001: Fix race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.
Date Thu, 05 May 2016 04:15:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47001/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jiang Yan Xu.


Bugs: MESOS-5308
    https://issues.apache.org/jira/browse/MESOS-5308


Repository: mesos


Description
-------

There are two race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.
The first is when we were checking the disk resources consumed
without knowing whether the dd command had completed. We can just
eliminate this check since other tests cover the resource usage
case. The second race was installing the
MesosContainerizerProcess::___recover expectation after starting
the slave. We need to install this before starting.


Diffs
-----

  src/tests/containerizer/xfs_quota_tests.cpp 61ea2e55e5c71cb10f6c84d23c205169567e8c96 

Diff: https://reviews.apache.org/r/47001/diff/


Testing
-------

Fedora 23.

$ mesos-tests --gtest_filter=ROOT_XFS_QuotaTest.NoCheckpointRecovery --gtest_repeat=10000
--gtest_break_on_failure


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message