mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.
Date Thu, 05 May 2016 13:43:19 GMT


> On May 4, 2016, 3:24 a.m., Kapil Arya wrote:
> > src/common/http.cpp, line 599
> > <https://reviews.apache.org/r/46883/diff/1/?file=1368228#file1368228line599>
> >
> >     Does non-existing `subject` mean "ANY"?

Yep, that's correct. In the local authorizer code (src/authorizer/local/authorizer.cpp), in
the private definition of `LocalAuthorizerProcess::authorized`, we set the subject to ANY
if it hasn't already been set.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46883/#review131616
-----------------------------------------------------------


On May 5, 2016, 1:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46883/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 1:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a callback to the generating
> function `CreateAuthorizationCallbacks` for the
> '/metrics/snapshot' endpoint.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
> 
> Diff: https://reviews.apache.org/r/46883/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message