mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.
Date Thu, 05 May 2016 21:45:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131946
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 32)
<https://reviews.apache.org/r/46620/#comment195986>

    `Name() = default;`



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (lines 34 - 38)
<https://reviews.apache.org/r/46620/#comment195988>

    `s/_value/value/`



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 40)
<https://reviews.apache.org/r/46620/#comment195987>

    (1) Can we make this `private` and add a `const std::string& get() const { return
value; }`
    (2) `s/value/value_/`


- Michael Park


On April 30, 2016, 1:56 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29

>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21

> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message