mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 46373: Request /files/read.json with a negative length value causes error.
Date Fri, 06 May 2016 05:08:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/
-----------------------------------------------------------

(Updated 五月 6, 2016, 5:08 a.m.)


Review request for mesos, Ben Mahler and Greg Mann.


Changes
-------

rebased the code


Bugs: mesos-5060
    https://issues.apache.org/jira/browse/mesos-5060


Repository: mesos


Description
-------

[MESOS-5060]
The patch did the following changes:
1. Fix the length logic in files.cpp.
2. Add some tests to test the /files/read.json endponit with
negative length.


Diffs (updated)
-----

  src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
  src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 

Diff: https://reviews.apache.org/r/46373/diff/


Testing
-------

make
make check

request 'files/read.json' endpoint with negative offset or length argument


Thanks,

zhou xing


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message