mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.
Date Fri, 06 May 2016 10:47:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review132008
-----------------------------------------------------------




include/mesos/authorizer/acls.proto (line 168)
<https://reviews.apache.org/r/46613/#comment196043>

    s/of which users/for executors run as the given users/



include/mesos/authorizer/acls.proto (line 173)
<https://reviews.apache.org/r/46613/#comment196046>

    This isn't accurate either. Remember this is the RunAs user: the linux user that the agent
launches the container as, and the filesystem owner of the sandbox on disk.
    This is unrelated to a task's "owner", or the HTTP user that created a task in Marathon
or other framework UIs



include/mesos/authorizer/acls.proto (lines 177 - 182)
<https://reviews.apache.org/r/46613/#comment196047>

    Ditto



include/mesos/authorizer/authorizer.proto (lines 62 - 63)
<https://reviews.apache.org/r/46613/#comment196048>

    What about VIEW_EXECUTOR_WITH_INFO?


- Adam B


On May 4, 2016, 5:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5169
>     https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced VIEW_(FRAMEWORK,TASK}_WITH_INFO actions to authorizer.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59

>   src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message