mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Robinson <drobin...@twopensource.com>
Subject Re: Review Request 47080: Agent should backoff when establishing a socket.
Date Mon, 09 May 2016 19:36:00 GMT


> On May 9, 2016, 5:20 a.m., Cong Wang wrote:
> > src/slave/slave.cpp, line 954
> > <https://reviews.apache.org/r/47080/diff/1/?file=1375586#file1375586line954>
> >
> >     One thing to note is the authentication could need a connect with master, so
this could impact it. But essentially we need a backoff for authentication too.

Yeah, perhaps the call to authenticate() should be moved within doReliableRegistration() too.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47080/#review132205
-----------------------------------------------------------


On May 6, 2016, 10:51 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47080/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 10:51 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
>     https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent should backoff when establishing a socket.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47080/diff/
> 
> 
> Testing
> -------
> 
> make tests
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the connection is only
established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message