mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46504: Constructed error string in MethodNotAllowed.
Date Tue, 10 May 2016 16:47:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46504/#review132463
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix one minor nit and commit this for you.


3rdparty/libprocess/include/process/http.hpp (lines 587 - 588)
<https://reviews.apache.org/r/46504/#comment196656>

    `clang-format` suggests the following:
    ```
        : Response(
            constructBody(allowedMethods, requestMethod),
            Status::METHOD_NOT_ALLOWED)
    ```


- Alexander Rukletsov


On May 9, 2016, 10:21 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46504/
> -----------------------------------------------------------
> 
> (Updated May 9, 2016, 10:21 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4126
>     https://issues.apache.org/jira/browse/MESOS-4126
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Constructed error string in MethodNotAllowed.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297

> 
> Diff: https://reviews.apache.org/r/46504/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message