mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Pravat <dpra...@outlook.com>
Subject Re: Review Request 47052: Windows: [1/2] Added `os::random`.
Date Wed, 11 May 2016 06:05:53 GMT


> On May 10, 2016, 4:50 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, line 121
> > <https://reviews.apache.org/r/47052/diff/1/?file=1374432#file1374432line121>
> >
> >     I must have missed the context on this change -- we haven't upgraded the Windows
dependency on ZK, have we? Or at least, I haven't seen anything in my review dashboard about
it. So, it seems like htis should still interfere with `UUID::random`?
> >     
> >     For my own education, can you please comment a bit on why this `#undef` is no
longer necessary?

Zookeeper used to define random as rand. Initialy we were just trying to avoid the compilation
error by #udef ... Now we are defining a proper random() function in Zookeeper via the patch.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47052/#review132475
-----------------------------------------------------------


On May 11, 2016, 6:05 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47052/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 6:05 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [1/2] Added `os::random`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 0f71f66d3efed7513ce407dde5b56368747c8e70

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7a59e78575e1456b4e14d18ac97f51dd23d794e

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 261768eace6ab09956f4a80e1ec5dba988d831e1

> 
> Diff: https://reviews.apache.org/r/47052/diff/
> 
> 
> Testing
> -------
> 
> OSX: make 
> Windows: build
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message