mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.
Date Wed, 11 May 2016 18:32:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46530/#review132715
-----------------------------------------------------------


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46530/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
>     https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The variable $(top_srcdir) causes compilation failure if the Makefile is
> generated by top-level configure script instead of libprocess-specific
> configure script.
> 
> Also replaced ${abs_top_builddir} with ${abs_builddir}. This is used to
> compute path to ssl-client binary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
> 
> Diff: https://reviews.apache.org/r/46530/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message