mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.
Date Fri, 13 May 2016 15:31:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/#review133129
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp (lines 799 - 805)
<https://reviews.apache.org/r/41632/#comment197421>

    i just rewrapped these a little.


- Joris Van Remoortere


On May 12, 2016, 10:31 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41632/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 10:31 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,
and Michael Park.
> 
> 
> Bugs: MESOS-5373
>     https://issues.apache.org/jira/browse/MESOS-5373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added Console Ctrl handling in `slave.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/posix_signalhandler.hpp PRE-CREATION 
>   src/slave/slave.cpp feb9f291b4188aac1a63ab9cfae8349a048663b1 
>   src/slave/windows_ctrlhandler.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41632/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: make
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message