mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <benjamin.mah...@gmail.com>
Subject Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.
Date Fri, 13 May 2016 21:46:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47362/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil Conway.


Bugs: MESOS-5340
    https://issues.apache.org/jira/browse/MESOS-5340


Repository: mesos


Description
-------

This test works by creating a connection on which no data is sent (the SSL handshake does
not complete, nor is the socket downgraded). After which, we expect that an HTTP request should
succeed.


Diffs
-----

  3rdparty/libprocess/src/tests/ssl_tests.cpp 4d237815a03828b915e821c3af78132e2915c610 

Diff: https://reviews.apache.org/r/47362/diff/


Testing
-------

This test fails before the fix in MESOS-5340.

```
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SSLTest
[ RUN      ] SSLTest.SilentSocket
../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:752: Failure
Failed to wait 15secs for socket
[  FAILED  ] SSLTest.SilentSocket (15221 ms)
[----------] 1 test from SSLTest (15221 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (15222 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLTest.SilentSocket
```


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message