mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.
Date Sat, 14 May 2016 08:31:13 GMT


> On 五月 12, 2016, 11:44 p.m., Jojy Varghese wrote:
> > Srinivas, thanks for taking this on. It looks like you combined your previous patches
(https://reviews.apache.org/r/46107) here. I would advice you to split this patch into 2:
> >  - Protobuf changes
> >  - Other changes
> >  
> > 
> > -jojy
> 
> Srinivas Brahmaroutu wrote:
>     Hi Jojy, I would rebase as the other two patches get merged. This patch includes
other two patches https://reviews.apache.org/r/46107 and https://reviews.apache.org/r/46182
 I have cumlative patches. I may be wrong, but once https://reviews.apache.org/r/46107 is
checked in I will rebase 46182 and so on?

Srini, you can create a patch chain that have dependeny to resolve this, the steps could be
as this:
1) git checkout -b part1
2) Update your code and `support/post-review.sh`
3) git checkout -b part2 (This can make sure part2 depend on part1)
4) Update your code and `support/post-review.sh`
5) repeat 3) and 4) for other patches


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133004
-----------------------------------------------------------


On 五月 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> -----------------------------------------------------------
> 
> (Updated 五月 14, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -----
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/containerizer.cpp 75e5a32a3e70ec60a6800e21a621673184ea0956

>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 5c96e9f6603d39889e6bc807874d35d0cb3556be

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

>   src/tests/containerizer/provisioner_appc_tests.cpp 84fe52b6937c3b7d7628b17a2f045eec2f386b4d

> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message