mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.
Date Sat, 14 May 2016 13:55:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47360/#review133272
-----------------------------------------------------------




docs/persistent-volume.md (line 96)
<https://reviews.apache.org/r/47360/#comment197562>

    Can you please show more detail for `may take any value, or may be omitted.`
    
    a) In which condition can take any value if the framework did not provide a principal.
    b) In which condition the `principal` will be omitted if the framework did not provide
a principal.
    
    Ditto for others.


- Guangya Liu


On May 14, 2016, 12:39 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47360/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-5215
>     https://issues.apache.org/jira/browse/MESOS-5215
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the documentation of RESERVE and
> CREATE operations, both via offer operations and
> operator endpoints. Specifically, we clarify the
> Mesos master's expectations for the values of the
> `principal` fields found in `ReservationInfo` and
> `DiskInfo.Persistence`.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
>   docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f 
> 
> Diff: https://reviews.apache.org/r/47360/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message