mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 47396: Added aufs provisioning backend.
Date Sun, 15 May 2016 13:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133300
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/backend.cpp (line 32)
<https://reviews.apache.org/r/47396/#comment197604>

    Move this above `bind.hpp`
    
    #ifdef __linux__
    #include "slave/containerizer/mesos/provisioner/backends/aufs.hpp"
    #endif


- Guangya Liu


On 五月 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> -----------------------------------------------------------
> 
> (Updated 五月 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
>     https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp b2a20b7c08fa790da09ba05b725248e42b8d3bc4

>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp bc04760c9504ea55cd4bb72c7e9012e43a5911aa

>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> -------
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script that launches
tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message