mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45200: Add deprecated flag names.
Date Mon, 16 May 2016 02:24:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review133314
-----------------------------------------------------------



LGTM, modulo un-needed tests. 

Can you follow up with a review that actually changes the flag variables (e.g., flags.slave_rereigster_timeout)
from slave -> agent as well?


src/tests/flags_tests.cpp (line 2)
<https://reviews.apache.org/r/45200/#comment197623>

    I don't think we need these tests since we already have tests for deprecated flag names.
Just kill this file.


- Vinod Kone


On May 15, 2016, 11:27 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 11:27 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3781
>     https://issues.apache.org/jira/browse/MESOS-3781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace 'slave' with 'agent' in flag names. Original names are marked
> as deprecated.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/master/flags.cpp b97f01149b428a736d052cf7aece8ae092ca8cd4 
>   src/slave/flags.cpp b7df8f760d0f75459f1e80e3d8e18d49a3995df8 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45200/diff/
> 
> 
> Testing
> -------
> 
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message