mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.
Date Mon, 16 May 2016 18:10:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/
-----------------------------------------------------------

(Updated May 16, 2016, 11:10 a.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Kapil Arya, and Jan Schlicht.


Changes
-------

Rebase and remove dependency.


Repository: mesos


Description
-------

This gives external projects easier access to the test helpers used in
mesos tests.  

For example, a module writer may want to write a test like 
`src/tests/oversubscription_tests.cpp`.  To build and link against 
this library, the module writer would mimic the build flags for tests:
```
my_module_CPPFLAGS =                   \
  -I$(ZOOKEEPER)/include               \
  -I$(ZOOKEEPER)/generated             \
  -DSOURCE_DIR=\"$(abs_top_srcdir)\"   \
  -DBUILD_DIR=\"$(abs_top_builddir)\"  \
  ...
```


Diffs (updated)
-----

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 

Diff: https://reviews.apache.org/r/47374/diff/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message