mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 47365: Moved code from HTTP command executor to command executor.
Date Mon, 16 May 2016 23:50:08 GMT


> On May 15, 2016, 12:55 a.m., Vinod Kone wrote:
> > src/launcher/executor.cpp, line 104
> > <https://reviews.apache.org/r/47365/diff/1/?file=1383169#file1383169line104>
> >
> >     s/HttpCommandExecutor/CommandExecutor/

Updated in https://reviews.apache.org/r/47431


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47365/#review133290
-----------------------------------------------------------


On May 13, 2016, 10:33 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47365/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
>     https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change makes reviewing code later in the chain easier.
> Later in the chain, we would make this use the Shim/Adapter
> to toggle between using the driver or the v1 API via an
> environment variable. `http_command_executor.cpp` would
> be deleted.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 7d111e668e0a139a98bdeb959997843180b40452 
> 
> Diff: https://reviews.apache.org/r/47365/diff/
> 
> 
> Testing
> -------
> 
> make check
> (this should not be committed on its own)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message