mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 47364: Set env variable used to toggle executor implementation.
Date Mon, 16 May 2016 23:50:33 GMT


> On May 15, 2016, 12:55 a.m., Vinod Kone wrote:
> > src/slave/containerizer/containerizer.cpp, line 364
> > <https://reviews.apache.org/r/47364/diff/1/?file=1383168#file1383168line364>
> >
> >     How about
> >     
> >     MESOS_HTTP_API
> >     
> >     Also, should this be only set if it's a command executor?

As per our offline discussion, would file a JIRA to do a sweep of other environment variables
that are not used by the HTTP API but are part of the `executorEnvironment` method.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47364/#review133291
-----------------------------------------------------------


On May 13, 2016, 10:34 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47364/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5063
>     https://issues.apache.org/jira/browse/MESOS-5063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the environment variable that is set by
> the agent allowing the command executor to toggle between
> implementations.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp d0cae79834e451594d7675f00c5f7d2d2cd3a264

> 
> Diff: https://reviews.apache.org/r/47364/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message