mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.
Date Tue, 17 May 2016 02:14:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47089/
-----------------------------------------------------------

(Updated May 17, 2016, 2:14 a.m.)


Review request for mesos, Benjamin Mahler, Niklas Nielsen, Timothy Chen, and Jiang Yan Xu.


Changes
-------

Removed Clock advance because it could not work on a subprocess.


Bugs: MESOS-1653
    https://issues.apache.org/jira/browse/MESOS-1653


Repository: mesos


Description
-------

Waited for first statusUpdate before advance clock in GracePeriod test.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/47089/diff/


Testing
-------

Test with

```
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.GracePeriod" --verbose --gtest_break_on_failure
--gtest_repeat=-1
```

more than 1500 iteractions in my slow machine.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message